Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-4366 enable resurrection tests #7229

Merged
merged 4 commits into from
Dec 5, 2024
Merged

CBG-4366 enable resurrection tests #7229

merged 4 commits into from
Dec 5, 2024

Conversation

torcolvin
Copy link
Collaborator

Switch tests to use fewer buckets: for each topology use use one bucket and then each actor will run tests in sequence. Using subtests allows to run each test individually if necessary.

Need to update tb on each peer for each subtest to avoid subtest may have called FailNow on a parent test error.

The integration tests can still fail but they don't seem to fail more frequently than the old code. I haven't seen failures in jenkins, but I might not have run them frequently enough.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@torcolvin torcolvin assigned gregns1 and adamcfraser and unassigned gregns1 Dec 4, 2024
Copy link
Contributor

@gregns1 gregns1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I ran tests in goland and it feels much nicer having each subtest under each topology.
I was trying to think of a way to integrate the updatePeersT call into the test so whoever is writing a test wouldn't have to remember to do it (I would totally forget) but I'm not sure there is an easy way to do that so I'm good with it as is! 😄

@torcolvin torcolvin enabled auto-merge (squash) December 5, 2024 15:44
@torcolvin torcolvin merged commit ed1a401 into release/anemone Dec 5, 2024
36 checks passed
@torcolvin torcolvin deleted the CBG-4366 branch December 5, 2024 16:27
bbrks pushed a commit that referenced this pull request Dec 5, 2024
bbrks pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants