CBG-4265 avoid panic in rosmar xdcr tests #7231
Merged
+72
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- return an error if xdcr is already running when Start is called, or already stopped when Stop is called - allow rosmar xdcr to be restarted via Start/Stop/Start by resetting terminator - don't return empty topology in Topologies which causes test panic - enable rosmar multi actor conflict tests - remove a test that is a duplicate of existing test
… stopping and starting very quickly
adamcfraser
approved these changes
Dec 6, 2024
adamcfraser
approved these changes
Dec 9, 2024
bbrks
pushed a commit
that referenced
this pull request
Dec 17, 2024
* CBG-4265 avoid panic in rosmar xdcr tests - return an error if xdcr is already running when Start is called, or already stopped when Stop is called - allow rosmar xdcr to be restarted via Start/Stop/Start by resetting terminator - don't return empty topology in Topologies which causes test panic - enable rosmar multi actor conflict tests - remove a test that is a duplicate of existing test * lock setting up collections in the case that dcp feed is running when stopping and starting very quickly * switch to require and CollectT * improve debug message * skip test with cbs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
already stopped when Stop is called
terminator
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiI'm waiting to understand why XDCR tests are failing with jenkins, which I do not think is related to the content of this commit:
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2866/