refactor topologytests #7238
Merged
refactor topologytests #7238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamcfraser
approved these changes
Dec 12, 2024
bbrks
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Move tests into separate files to make it easier to enable/disable groups * shorten document names for readability * add missing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only moves and renames tests, to make it easier to comment out tests for a particular section of tests in a file and see unique tests.
[]PeerReplicationfor readability and rename test docs to be a bit shorter.%#vMultiActor non conflicting tests don't have a test plan because I think they might be testing the wrong thing, they are testing separate documents but I think they should be testing the same document with the same contents, but not sure.
These tests don't consistently pass for CBS but I plan to disable all tests for CBS with an environment variable bypass for local testing. I don't think we get a lot out of having them run automatically in jenkins in the pre-beta period and most tests are skipped for couchbase server anyway. I'll file a separate PR for this.