Remove loading prop from Form.Textarea and Form.Input

couds · Jan 2, 2021 · f927308 · f927308
1 parent 8eaf9bf
commit f927308
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 16 deletions.
diff --git a/src/components/form/components/__test__/__snapshots__/textarea.test.js.snap b/src/components/form/components/__test__/__snapshots__/textarea.test.js.snap
@@ -22,7 +22,7 @@ exports[`Textarea component Should have textarea classname 1`] = `
 
 exports[`Textarea component Should support various states 1`] = `
 <textarea
-  className="textarea is-loading is-focused is-hovered"
+  className="textarea is-focused is-hovered"
 />
 `;
 

diff --git a/src/components/form/components/__test__/textarea.test.js b/src/components/form/components/__test__/textarea.test.js
@@ -21,7 +21,7 @@ describe('Textarea component', () => {
     expect(component.toJSON()).toMatchSnapshot();
   });
   it('Should support various states', () => {
-    const component = renderer.create(<Textarea loading focused hovered />);
+    const component = renderer.create(<Textarea focused hovered />);
     expect(component.toJSON()).toMatchSnapshot();
   });
   it('Should have a fixed size', () => {

diff --git a/src/components/form/components/input.js b/src/components/form/components/input.js
@@ -53,10 +53,6 @@ Input.propTypes = {
    * are removed.
    */
   isStatic: PropTypes.bool,
-  /**
-   * Whether this input is in a loading state.
-   */
-  loading: PropTypes.bool,
   /**
    * Whether this input is in a focused state.
    */
@@ -87,7 +83,6 @@ Input.defaultProps = {
   focused: false,
   hovered: false,
   rounded: false,
-  loading: false,
   renderAs: 'input',
 };
 

diff --git a/src/components/form/components/textarea.js b/src/components/form/components/textarea.js
@@ -12,7 +12,6 @@ const Textarea = ({
   className,
   size,
   color,
-  loading,
   focused,
   hovered,
   fixedSize,
@@ -21,7 +20,6 @@ const Textarea = ({
   <Element
     {...props}
     className={classnames('textarea', className, {
-      'is-loading': loading,
       'is-focused': focused,
       'is-hovered': hovered,
       'has-fixed-size': fixedSize,
@@ -47,10 +45,6 @@ Textarea.propTypes = {
    * The color of this input.
    */
   color: PropTypes.oneOf(colors),
-  /**
-   * Whether this textarea is in a loading state.
-   */
-  loading: PropTypes.bool,
   /**
    * Whether this textarea is in a focused state.
    */
@@ -77,7 +71,6 @@ Textarea.defaultProps = {
   size: undefined,
   focused: false,
   hovered: false,
-  loading: false,
   fixedSize: false,
   color: undefined,
 };

diff --git a/src/components/form/index.d.ts b/src/components/form/index.d.ts
@@ -31,7 +31,6 @@ interface InputProps<T> {
   color?: Color;
   readOnly?: boolean;
   isStatic?: boolean;
-  loading?: boolean;
   focused?: boolean;
   hovered?: boolean;
   value?: T;
@@ -46,7 +45,6 @@ interface TextareaProps {
   color?: Color;
   focused?: boolean;
   hovered?: boolean;
-  loading?: boolean;
   fixedSize?: boolean;
 }