Added Blockheight and Version #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarassh
reviewed
Aug 26, 2024
| @@ -29,6 +30,8 @@ type message struct { | |||
| Commitment string `json:"commitment"` | |||
| Proof string `json:"proof"` | |||
| Cell string `json:"cell"` | |||
| BlockHeight uint `json:"block_height"` | |||
There was a problem hiding this comment.
Lets use the same type as in event uint64
tarassh
reviewed
Aug 26, 2024
| @@ -89,6 +92,9 @@ func (p *Publisher) PublishToCS(cid string, rowIndex int, colIndex int, status b | |||
| Commitment: base64.StdEncoding.EncodeToString(commitment), | |||
| Proof: base64.StdEncoding.EncodeToString(proof), | |||
| Cell: base64.StdEncoding.EncodeToString(cell), | |||
| BlockHeight: blockHeight, | |||
| Version: common.Version, | |||
There was a problem hiding this comment.
Version: fmt.Sprintf("%s-%s", common.Version, common.Commit)
tarassh
requested changes
Aug 26, 2024
tarassh
reviewed
Aug 26, 2024
| @@ -109,6 +109,6 @@ func (el *EventListener) ProcessLogs() { | |||
| continue | |||
| } | |||
|
|
|||
| el.sampler.ProcessEvent(parsedURL.Host, uint(event.BlockHeight)) | |||
| el.sampler.ProcessEvent(parsedURL.Host, uint64(event.BlockHeight)) | |||
There was a problem hiding this comment.
BlockHeight is of type uint64, no need to use type conversion.
tarassh
reviewed
Aug 26, 2024
| @@ -97,6 +98,8 @@ func (p *Publisher) PublishToCS(cid string, rowIndex int, colIndex int, status b | |||
|
|
|||
| } | |||
|
|
|||
| fmt.Sprintf("%s-%s", common.Version, common.GitCommit) | |||
There was a problem hiding this comment.
The result should go to Version.
tarassh
reviewed
Aug 26, 2024
| } | ||
|
|
||
| fmt.Printf("%s-%s", common.Version, common.GitCommit) |
tarassh
requested changes
Aug 26, 2024
tarassh
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Blockheight and Version fields to Pubsub