Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(atomic): fix flaky atomic did you mean tests #4723

Merged
merged 4 commits into from
Nov 26, 2024
Merged

test(atomic): fix flaky atomic did you mean tests #4723

merged 4 commits into from
Nov 26, 2024

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme commented Nov 26, 2024 •
edited
Loading

https://coveord.atlassian.net/browse/CDX-1595

I don't know why but this makes it less flaky locally.

  • also fix external.e2e.ts

@alexprudhomme alexprudhomme requested a review from a team as a code owner November 26, 2024 13:30
@github-actions GitHub Actions
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 242.6 242.6 0
commerce 347.3 347.3 0
search 413.8 413.8 0
insight 404.9 404.9 0
recommendation 254.9 254.9 0
ssr 407.3 407.3 0
ssr-commerce 359.6 359.6 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme marked this pull request as draft November 26, 2024 15:42
@alexprudhomme alexprudhomme marked this pull request as ready for review November 26, 2024 18:09
@alexprudhomme alexprudhomme added this pull request to the merge queue Nov 26, 2024
@alexprudhomme alexprudhomme removed this pull request from the merge queue due to a manual request Nov 26, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Nov 26, 2024
Merged via the queue into master with commit ea85966 Nov 26, 2024
122 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Nov 26, 2024
@alexprudhomme
test(atomic): fix flaky atomic did you mean tests (#4723)
ea85966 
https://coveord.atlassian.net/browse/CDX-1595

I don't know why but this makes it less flaky locally.
- [x] also fix external.e2e.ts
@alexprudhomme alexprudhomme deleted the CDX-1595-2 branch November 26, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeaudoincoveo fbeaudoincoveo fbeaudoincoveo approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexprudhomme @fbeaudoincoveo