Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(headless commerce SSR): copy common codes/sample between NextJS & Remix #4778

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

docs(headless commerce SSR): copy common codes/sample between NextJS & Remix #4778

wants to merge 29 commits into from
+1,937 −64

Conversation

fpbrault
Copy link
Contributor

@fpbrault fpbrault commented Dec 6, 2024

This PR updates the Remix sample to include the same components as the NextJS sample.

https://coveord.atlassian.net/browse/KIT-3774

@fpbrault fpbrault marked this pull request as ready for review December 6, 2024 22:16
@fpbrault fpbrault requested a review from a team as a code owner December 6, 2024 22:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 242.9 242.9 0
commerce 354 354 0
search 414 414 0
insight 405.2 405.2 0
recommendation 255.1 255.1 0
ssr 407.4 407.4 0
ssr-commerce 371.3 371.3 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

fbeaudoincoveo
fbeaudoincoveo reviewed Dec 10, 2024
View reviewed changes
packages/samples/headless-commerce-ssr-remix/app/components/breadcrumb-manager.tsx Outdated Show resolved Hide resolved
packages/samples/headless-commerce-ssr-remix/app/components/breadcrumb-manager.tsx Show resolved Hide resolved
packages/samples/headless-commerce-ssr-remix/app/components/context-dropdown.tsx Outdated Show resolved Hide resolved
packages/samples/headless-commerce-ssr-remix/app/components/context-dropdown.tsx Outdated Show resolved Hide resolved
packages/samples/headless-commerce-ssr-remix/app/components/did-you-mean.tsx Outdated Show resolved Hide resolved
packages/samples/headless-commerce-ssr-remix/app/components/recent-queries.tsx Outdated Show resolved Hide resolved
packages/samples/headless-commerce-ssr-remix/app/components/recommendations/popular-bought.tsx Outdated Show resolved Hide resolved
packages/samples/headless-commerce-ssr-remix/app/components/sort.tsx Outdated Show resolved Hide resolved
packages/samples/headless-commerce-ssr-remix/app/components/sort.tsx Show resolved Hide resolved
packages/samples/headless-commerce-ssr-remix/app/components/standalone-search-box.tsx Show resolved Hide resolved
Base automatically changed from KIT-3704 to master December 16, 2024 19:45
@fpbrault fpbrault requested a review from a team as a code owner December 17, 2024 15:31
@fpbrault fpbrault marked this pull request as draft December 17, 2024 15:32
@fpbrault fpbrault removed the request for review from a team December 17, 2024 15:37
@fpbrault fpbrault force-pushed the KIT-3774 branch 4 times, most recently from fdb0b53 to ebf2fee Compare December 17, 2024 21:53
GitHub Actions Bot and others added 18 commits December 18, 2024 11:44
@fpbrault
Add generated files
faf7751 
https://coveord.atlassian.net/browse/KIT-3774
@fpbrault
disable recs
688e37b 
https://coveord.atlassian.net/browse/KIT-3774
@fpbrault
remove use client
bffc21e 
https://coveord.atlassian.net/browse/KIT-3774
@fpbrault
use context api
6d205f2 
https://coveord.atlassian.net/browse/KIT-3774
@fpbrault
remove unused component
ec39256 
https://coveord.atlassian.net/browse/KIT-3774
@fpbrault @fbeaudoincoveo
Apply suggestions from code review
ff4cd08 
Co-authored-by: Frederic Beaudoin <fbeaudoin@coveo.com>
@fpbrault
fix summary
9c0fcd4 
https://coveord.atlassian.net/browse/KIT-3774
@fpbrault
add didyoumean
fa4b5c6 
https://coveord.atlassian.net/browse/KIT-3774
@fpbrault
add sort on search
4f49767 
https://coveord.atlassian.net/browse/KIT-3774
@fpbrault
add parameter manager
dc9fec9 
https://coveord.atlassian.net/browse/KIT-3774
@fpbrault
remove unneeded interface declarations
902420d 
https://coveord.atlassian.net/browse/KIT-3774
@fpbrault
add todo for location facet
3283086 
https://coveord.atlassian.net/browse/KIT-3774
@fpbrault
enable recs
62acada 
https://coveord.atlassian.net/browse/KIT-3774
@fpbrault
combined rec components
c941926 
https://coveord.atlassian.net/browse/KIT-3774
@fpbrault
use fragment instead of query params
c4523cd 
https://coveord.atlassian.net/browse/KIT-3774
@fpbrault
improve searchbox
5b030fe 
https://coveord.atlassian.net/browse/KIT-3774
@fpbrault
fix build
da672ec 
https://coveord.atlassian.net/browse/KIT-3774
@fpbrault
Add generated files
ed662d4 
https://coveord.atlassian.net/browse/KIT-3774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/search

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpbrault @fbeaudoincoveo