Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(atomic): fix IPX with high zoom levels #4805

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dguerinCoveo
Copy link
Contributor

@dguerinCoveo dguerinCoveo commented Dec 20, 2024

SVCC-4253

Adds some style to IPX to handle big zoom levels and mobile view. See video.

Before

Screen.Recording.2024-12-20.at.1.38.17.PM.mov

After

Screen.Recording.2024-12-20.at.1.34.35.PM.mov

@dguerinCoveo dguerinCoveo marked this pull request as ready for review December 20, 2024 18:41
@dguerinCoveo dguerinCoveo requested a review from a team as a code owner December 20, 2024 18:41
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 242.9 242.9 0
commerce 354 354 0
search 414 414 0
insight 405.2 405.2 0
recommendation 255.1 255.1 0
ssr 407.4 407.4 0
ssr-commerce 371.3 371.3 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Copy link
Contributor

@mikegron mikegron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maudit rem..

@dguerinCoveo dguerinCoveo added this pull request to the merge queue Dec 23, 2024
@dguerinCoveo dguerinCoveo removed this pull request from the merge queue due to a manual request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants