Build macOS ARM binaries + update goreleaser #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pballandras
approved these changes
Nov 25, 2021
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
+ Coverage 55.75% 55.80% +0.04%
==========================================
Files 62 62
Lines 4084 4084
==========================================
+ Hits 2277 2279 +2
+ Misses 1631 1630 -1
+ Partials 176 175 -1
Continue to review full report at Codecov.
|
dotboris
approved these changes
Nov 26, 2021
|
|
||
| # Build one binary for Mac OS (arm64 and amd64) | ||
| universal_binaries: | ||
| - replace: true |
There was a problem hiding this comment.
From the looks of the build logs, it seems like this will make it so that we don't upload the darwin_amd64 binary anymore.
This could break things for anyone who's expecting that to be in the releases.
I'm not sure if it's a big deal honestly 🤷♂️
wtrep
approved these changes
Nov 26, 2021
jocgir
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.