Fix bug in unmanaged arguments processing #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jocgir
force-pushed
the
DT-7419-Fix-a-bug-in-argument-evaluation
branch
2 times, most recently
from
f0692e5
to
26dd1b7
Compare
jocgir
force-pushed
the
DT-7419-Fix-a-bug-in-argument-evaluation
branch
from
26dd1b7
to
26cc36a
Compare
- Fix a bug that was causing some arguments to be eaten when handling Unmanaged arguments - Add some tests - Fix deprecated warnings - Rename the master branch to main - Transfer the repository under coveooss
jocgir
force-pushed
the
DT-7419-Fix-a-bug-in-argument-evaluation
branch
from
26cc36a
to
a0752f5
Compare
lpbedard
approved these changes
Nov 13, 2024
jonapich
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various improvements and refactoring across multiple files to enhance the codebase's readability, maintainability, and functionality. The changes include adding new test cases, refactoring existing functions, and updating deprecated methods.
Test Enhancements:
app_test.go: Added new test cases to handle scenarios with mixed valid and invalid flags.Refactoring and Code Simplification:
flags.go: Refactored theparsemethod inflagGroupto simplify the handling of unmanaged flags and improve code readability. [1] [2] [3]parser.go: Simplified theNextmethod inParseContextby removing redundant conditions and simplifying the token parsing logic.Deprecated Method Updates:
parser_test.go,parsers_test.go: Replaced deprecatedioutil.TempFilewithos.CreateTempfor creating temporary files in tests. [1] [2] [3] [4] [5] [6]Consolidation of Test Cases:
parser_test.go: Consolidated multiple test functions into a single table-driven test function to improve test organization and coverage.These changes collectively aim to improve the robustness and clarity of the codebase, ensuring better handling of edge cases and more maintainable code.