Changes from automated code review

* Fix documentation indentation * Fix test naming * Include `IgnoreConfig` in tags
coveooss · May 21, 2021 · faa36ad · faa36ad
1 parent b0098e5
commit faa36ad
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/aws/data_source_aws_default_tags.go b/aws/data_source_aws_default_tags.go
@@ -14,7 +14,8 @@ func dataSourceAwsDefaultTags() *schema.Resource {
 
 func dataSourceAwsDefaultTagsRead(d *schema.ResourceData, meta interface{}) error {
 	conn := meta.(*AWSClient).DefaultTagsConfig
-	if err := d.Set("tags", conn.Tags.Map()); err != nil {
+	ignoreTagsConfig := meta.(*AWSClient).IgnoreTagsConfig
+	if err := d.Set("tags", conn.Tags.IgnoreConfig(ignoreTagsConfig).Map()); err != nil {
 		return err
 	}
 	d.SetId(meta.(*AWSClient).partition)

diff --git a/aws/data_source_aws_default_tags_test.go b/aws/data_source_aws_default_tags_test.go
@@ -8,7 +8,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 )
 
-func TestAWSDefaultTagsDataSource_basic(t *testing.T) {
+func TestAccAWSDefaultTagsDataSource_basic(t *testing.T) {
 	var providers []*schema.Provider
 
 	dataSourceName := "data.aws_default_tags.test"

diff --git a/website/docs/d/default_tags.markdown b/website/docs/d/default_tags.markdown
@@ -3,7 +3,7 @@ subcategory: ""
 layout: "aws"
 page_title: "AWS: aws_default_tags"
 description: |-
-Expose the default tags configured on the provider.
+  Expose the default tags configured on the provider.
 ---
 
 # Data Source: aws_default_Tags
@@ -20,7 +20,7 @@ provider "aws" {
   default_tags {
     tags = {
       Environment = "Test"
-      Name = "Provider Tag"
+      Name        = "Provider Tag"
     }
   }
 }
@@ -31,8 +31,8 @@ resource "aws_autoscaling_group" "group" {
   dynamic "tag" {
     for_each = data.aws_default_tags.tags.tags
     content {
-      key = tag.key
-      value = tag.value
+      key                 = tag.key
+      value               = tag.value
       propagate_at_launch = true
     }
   }