Added missing features on parameter store resource #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow detection of key_id change
… error if the parameter no longer exist. If a user manually delete a parameter, Terraform is no longer able to recreate it or destroy it. The defautt value for overwrite should be true. Otherwise, this is causing a breaking change with previously written code where overwrite is not set and the behaviour was to overwrite the parameter by default. Moreover, terraform already provides a mechanism to handle the lifecycle of the values.
jocgir
pushed a commit
that referenced
this pull request
Oct 13, 2017
…pdate Update lightsail_instance.html.markdown
jocgir
pushed a commit
that referenced
this pull request
May 1, 2018
hi @nicksantamaria , thanks for the contribution and the helpful feedback on this PR.
jocgir
pushed a commit
that referenced
this pull request
Jul 3, 2018
make glue crawler creation wait for role ready
jocgir
pushed a commit
that referenced
this pull request
Apr 25, 2019
* Update sagemaker_endpoint_configuration not found message when reading resources * Update sagemaker_endpoint error when resource is NotFound * Fix ResourceNotFound to ValidationException
julienduchesne
pushed a commit
that referenced
this pull request
Jul 8, 2019
Update ecr_repository_policy.html.markdown
jocgir
pushed a commit
that referenced
this pull request
Mar 20, 2020
julienduchesne
pushed a commit
that referenced
this pull request
Sep 10, 2020
* Implementation of resource new resource type for GuardDuty S3 Export (hashicorp#10920) * Added tests and documentation * Fixed test namings * Fixed linter issues and removed explicit import test case * Fixed HCL formatting in documentation * Fixed some namings and sidebar link * Update/refactor publishing destination (#1) * Merged latest master changes and resolved conflicts * Merged from Upstream master and squashed commits * Delete defaults.go * Removed changes from vendor subdirectory and synched with master. * Refactor GuardDuty to waiter pattern * Remove unused constant * Small refactor based on PR review * Add disappears test and refactor based on PR review * Refactor based on PR review * Refactor according to PR review * Additional fix wrt tf 0.12 Co-authored-by: Sebastian Häpe <Sebastian.Haepe@nordcloud.com> Co-authored-by: shaepe <44882151+shaepe@users.noreply.github.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for description, allowed_pattern and tags for ssm parameters
Allow detection of key_id change