Allow to force s3 object content type to be able to retreive the body… #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for known object content
pastjean
suggested changes
Sep 5, 2017
| @@ -110,6 +113,7 @@ func dataSourceAwsS3BucketObjectRead(d *schema.ResourceData, meta interface{}) e | |||
|
|
|||
| bucket := d.Get("bucket").(string) | |||
| key := d.Get("key").(string) | |||
| forceContentType := d.Get("force_content_type").(string) | |||
There was a problem hiding this comment.
forcedContentType same for the parameter forced_content_type
sergeohl
approved these changes
Sep 5, 2017
…the content type to force it to be considered as text Added the required documentation
julienduchesne
pushed a commit
that referenced
this pull request
Feb 18, 2019
jocgir
pushed a commit
that referenced
this pull request
Apr 25, 2019
julienduchesne
pushed a commit
that referenced
this pull request
Jul 8, 2019
jocgir
pushed a commit
that referenced
this pull request
Jun 26, 2020
fixing retry logic - DescribeTags returns no err and an empty list of…
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for known object content
Use case:
We want to be able to read the content of a certificate from an s3 object. However, the mime type being
application/x-x509-ca-cert, even though it is in text format, the regular expression blocks the retrieval of the body. This parameter tells terraform to process this content as what you are expecting.