don't set the API_VERSION anymore, ensure minimum version through code #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonapich
requested review from
wtrep,
dblanchette,
dotboris,
pballandras and
jocgir
pballandras
approved these changes
Oct 13, 2022
dotboris
reviewed
Oct 13, 2022
wtrep
approved these changes
Oct 13, 2022
dotboris
approved these changes
Oct 13, 2022
Co-authored-by: William Trépanier <39393794+wtrep@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the
DOCKER_API_VERSIONprevents using updated APIs; this was not the goal. The current PR will query the client version and compare against a range of allowed versions: