Fetch latest TGF release from GH API for install scripts #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotboris
requested review from
jonapich,
dblanchette,
pballandras,
wtrep and
dlevesque-coveo
jonapich
approved these changes
Jul 12, 2023
pballandras
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the install scripts rely on a text file hosted on AWS S3 which holds the latest release of TGF. The link between this file and the latest release on GH is managed by some infrastructure at Coveo. We would like to get rid of that infrastructure.
To allow that, this PR changes the install scripts so that they query the GitHub API to figure out what the latest release is. This matches the behaviour of the auto-update feature within TGF itself.