Fix goreleaser & revamp CI & repo in general #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pballandras
approved these changes
Jul 13, 2023
| - name: Setup Go | ||
| uses: actions/setup-go@v3 | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-go@v4 | ||
| with: | ||
| go-version: 1.17 |
There was a problem hiding this comment.
1.17 is getting old, could we either bump this one or matrix (like we for os) it to test more modern go versions as well maybe?
| 1. Create a tag with the format `vX.Y.Z` | ||
|
|
||
| You might be tempted to create a release through GitHub to create the tag. | ||
| Don't do that. We have a GitHub workflow in place that will create a release |
There was a problem hiding this comment.
oof that's what I always did 😅 I think it just updates the release if it exists, but I'm not going to be the workflow breaker.
jonapich
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release is all broken because goreleaser was updated but we didn't migrate the config.
At least that's how it started. I realized that this repo was in need of some love so I did the following:
goreleaserto publish the releases it creates. Having to publish it manually is easy to forget and plain old busywork.goreleaserto the CIgoreleaser release ... --rm-disttogoreleaser relrease ... --cleanactions/setup-goto v4 (we get caching for free 🎉)