Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added node in HTML and CSS #3

Open
wants to merge 1 commit into
base: CoveoFoundation
Choose a base branch
from

Conversation

vbernard-coveo
Copy link
Collaborator

Custom animation done

Copy link

@francoislg francoislg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça donne quoi concrètement? GIF?

T'as juste fait 1 carré qui spin et l'autre qui fold? :P

@@ -34,6 +34,7 @@
data-auto-trigger-query="@Model.AutoTriggerQuery"
data-design="new"
data-enable-collaborative-rating="true"
data-first-loading-animation-selector="#loader-wrapper"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignement => tabs VS spaces

@@ -50,6 +51,13 @@
</div>
}

<div id="loader-wrapper" class="loader-wrapper">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird d'avoir le même ID que class.

Si tu en a pas besoin, retire le.

display: none;
}

.loader {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loader est tellement générique, tu peux tu scoper ou ajoute coveo- en avant de chacun d'entre eux, genre coveo-is-loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants