Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix]Fix instrumentation serialization bug #458

Merged

Conversation

MarcoRossignoli
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli commented Jun 7, 2019

Fixes #452

Tested with @AdmiringWorm repo

D:\git\Cake.Codecov\Source\Cake.Codecov.Tests (develop -> origin)
λ dotnet --info
.NET Core SDK (reflecting any global.json):
 Version:   2.1.603
 Commit:    ae71c68742
...
D:\git\Cake.Codecov\Source\Cake.Codecov.Tests (develop -> origin)
λ dotnet test /p:CollectCoverage=true /p:Exclude="[xunit.*]*" /p:CoverletToolsPath=D:\git\coverlet\src\coverlet.msbuild.tasks\bin\Debug\netstandard2.0\
Test run for D:\git\Cake.Codecov\Source\Cake.Codecov.Tests\bin\Debug\netcoreapp2.0\Cake.Codecov.Tests.dll(.NETCoreApp,Version=v2.0)
Microsoft (R) Test Execution Command Line Tool Version 16.0.1
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
[xUnit.net 00:00:00.76]     Cake.Codecov.Tests.CodecovRunnerTests.Should_Use_Codecov_Runner_From_Tool_Path_If_Provided_On_Unix [SKIP]
Skipped  Cake.Codecov.Tests.CodecovRunnerTests.Should_Use_Codecov_Runner_From_Tool_Path_If_Provided_On_Unix

Total tests: 33. Passed: 32. Failed: 0. Skipped: 1.
Test Run Successful.
Test execution time: 1.8148 Seconds

Calculating coverage result...
  Generating report 'D:\git\Cake.Codecov\Source\Cake.Codecov.Tests\coverage.json'

+--------------+------+--------+--------+
| Module       | Line | Branch | Method |
+--------------+------+--------+--------+
| Cake.Codecov | 100% | 100%   | 100%   |
+--------------+------+--------+--------+

+---------+------+--------+--------+
|         | Line | Branch | Method |
+---------+------+--------+--------+
| Total   | 100% | 100%   | 100%   |
+---------+------+--------+--------+
| Average | 100% | 100%   | 100%   |
+---------+------+--------+--------+

Test run for D:\git\Cake.Codecov\Source\Cake.Codecov.Tests\bin\Debug\net46\Cake.Codecov.Tests.dll(.NETFramework,Version=v4.6)
Microsoft (R) Test Execution Command Line Tool Version 16.0.1
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
[xUnit.net 00:00:00.76]     Cake.Codecov.Tests.CodecovRunnerTests.Should_Use_Codecov_Runner_From_Tool_Path_If_Provided_On_Unix [SKIP]
Skipped  Cake.Codecov.Tests.CodecovRunnerTests.Should_Use_Codecov_Runner_From_Tool_Path_If_Provided_On_Unix

Total tests: 33. Passed: 32. Failed: 0. Skipped: 1.
Test Run Successful.
Test execution time: 2.0821 Seconds

Calculating coverage result...
  Generating report 'D:\git\Cake.Codecov\Source\Cake.Codecov.Tests\coverage.json'

+--------------+------+--------+--------+
| Module       | Line | Branch | Method |
+--------------+------+--------+--------+
| Cake.Codecov | 100% | 100%   | 100%   |
+--------------+------+--------+--------+

+---------+------+--------+--------+
|         | Line | Branch | Method |
+---------+------+--------+--------+
| Total   | 100% | 100%   | 100%   |
+---------+------+--------+--------+
| Average | 100% | 100%   | 100%   |
+---------+------+--------+--------+

Tested also with "old" code and it break with sdk 2.1.603 as expected.

cc: @tonerdo

@MarcoRossignoli MarcoRossignoli changed the title Fix instrumentation serializaton bug Fix instrumentation serialization bug Jun 7, 2019
@MarcoRossignoli MarcoRossignoli changed the title Fix instrumentation serialization bug [Bug fix]Fix instrumentation serialization bug Jun 11, 2019
@MarcoRossignoli MarcoRossignoli added the bug Something isn't working label Jun 11, 2019
@tonerdo tonerdo merged commit 7bd804d into coverlet-coverage:master Jun 17, 2019
@MarcoRossignoli MarcoRossignoli deleted the fixjsonserializerbug branch June 18, 2019 07:18
@JSkimming
Copy link

This bug fix has worked, as demonstrated by this PR JSkimming/Castle.Core.AsyncInterceptor#72 where I've taken the nightly build.

@JSkimming
Copy link

@MarcoRossignoli are you looking to get this out in a NuGet.org release? It'll help improve the score with dependabot 😉

Compatibility score for coverlet.msbuild 2.6.1 to 2.6.2

@MarcoRossignoli
Copy link
Collaborator Author

dependabot badge is cute!I think we should add to readme.

@JSkimming I think so we need to release also for collectors side #461 (comment)
@tonerdo takes care of nuget release, just a little patience 👍 !

@JSkimming
Copy link

ICan'tWait

Understood 😃

@MarcoRossignoli
Copy link
Collaborator Author

@JSkimming you can use nightly for the moment :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading coverlet.msbuild to 2.6.2 fails builds on travis that worked with earlier versions
3 participants