[Bug fix]Fix instrumentation serialization bug #458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #452
I changed serializer, now we use
DataContractSerializer
that doesn't need converters and follow guidelineshttps://docs.microsoft.com/en-us/visualstudio/code-quality/ca2300-do-not-use-insecure-deserializer-binaryformatter?view=vs-2019
https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2301-do-not-call-binaryformatter-deserialize-without-first-setting-binaryformatter-binder?view=vs-2019
Downgraded Newtosoft.Json ref in core dll because we risk to have issue with old SDK.
Updated debug doc with new
/p:CoverletToolsPath
usage thank's to @AArnott update, very useful.Tested with @AdmiringWorm repo
Tested also with "old" code and it break with sdk 2.1.603 as expected.
cc: @tonerdo