Improve coverage of async/await state machine #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
added
bug
MarcoRossignoli
commented
Jan 21, 2020
| @@ -83,15 +102,87 @@ public static List<BranchPoint> GetBranchPoints(MethodDefinition methodDefinitio | |||
| continue; | |||
| } | |||
|
|
|||
| /* | |||
| If method is a generated MoveNext we'll skip first branches (could be a switch or a series of branches) | |||
There was a problem hiding this comment.
Alg update
MarcoRossignoli
commented
Jan 21, 2020
| @@ -60,6 +60,25 @@ private static bool IsMoveNextInsideEnumerator(MethodDefinition methodDefinition | |||
| return false; | |||
| } | |||
|
|
|||
| private static bool IsRecognizedMoveNextInsideAsyncStateMachineProlog(MethodDefinition methodDefinition) | |||
There was a problem hiding this comment.
Alg update
MarcoRossignoli
commented
Jan 21, 2020
| operand.DeclaringType.Scope.Name == "System.Runtime") | ||
| ( | ||
| operand.DeclaringType.Scope.Name == "System.Runtime" || | ||
| operand.DeclaringType.Scope.Name == "netstandard" |
There was a problem hiding this comment.
include netstandard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #669
Changed alg to recognize initial async/state machine branches used to check "state machine" state, some branch could not be covered due to true/false async nature of code.
Check comment of
CecilSymbolHelper.GetBranchPointsfor full explanationFixed is complete check adding netstandard scope, if we're testing netstandard project with ValueTask the scope is not System.Runtime but netstandard.
cc: @abbotware @LeMorrow @moikot