-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve branch detection for lambda functions and async/await statements #702
Merged
MarcoRossignoli
merged 7 commits into
coverlet-coverage:master
from
matteoerigozzi:Lambda_Issue343
Jan 28, 2020
Merged
Improve branch detection for lambda functions and async/await statements #702
MarcoRossignoli
merged 7 commits into
coverlet-coverage:master
from
matteoerigozzi:Lambda_Issue343
Jan 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
added
enhancement
General enhancement request
tenet-coverage
Issue related to possible incorrect coverage
bug
Something isn't working
and removed
enhancement
General enhancement request
labels
Jan 24, 2020
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
MarcoRossignoli
approved these changes
Jan 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine!Thank's!
Merged
Thanks so much for this fix and 2.8.1 - it really cleaned up some of our coverage stats. |
@nycdotnet you can follow changelog for fix/feat here here https://github.com/tonerdo/coverlet/blob/master/Documentation/Changelog.md#release-date-2020-04-02 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #584
In case of nested compiler generated classes, only the root one presents the
CompilerGeneratedAttribute
So to detect the MoveNext() method inside an async state machine we need to check recoursively the declaring type for compiler generated attribute.
I also noticed that the operand of the instruction
ldfld
inside an async state machine prolog can beFieldDefinition
orFieldReference
.We can see the difference looking at generated IL:
After this updates we removed some unexpected branches generates by async state machines and the report is this
Here I propose a solution to remove last 2 unexpected branches, that seems to be generated invoking a method with a delegate parameter. I added more tests to check the fairness but I'm not completely sure about it.