Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pr 131 comments #135

Merged
merged 2 commits into from
Jan 21, 2024
Merged

chore: pr 131 comments #135

merged 2 commits into from
Jan 21, 2024

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented Jan 19, 2024

Description

This PR contains fixes for comments from #131

Changes

  • Fix readme error
  • Cleanup unused type in FilterPolicy
  • Add gitignore for default config file

How to test

  1. Follow README.md instructions for running locally.

@mfw78 mfw78 requested review from anxolin and a team January 19, 2024 07:13
@mfw78 mfw78 self-assigned this Jan 19, 2024
anxolin
anxolin approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with comments

.gitignore Outdated Show resolved Hide resolved
@mfw78 mfw78 merged commit 279f720 into main Jan 21, 2024
4 checks passed
@mfw78 mfw78 deleted the pr-131-comments branch January 21, 2024 18:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

Assignees

@mfw78 mfw78

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfw78 @anxolin