Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: metrics module #140

Merged
merged 1 commit into from
Jan 25, 2024
Merged

refactor: metrics module #140

merged 1 commit into from
Jan 25, 2024

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented Jan 23, 2024

Description

This refactors the metrics to make it more explicit when used within consuming code.

Changes

  • Metrics now scoped to a module

How to test

  1. Run in testing environment and observe metrics continue to work.

@mfw78 mfw78 added the enhancement New feature or request label Jan 23, 2024
@mfw78 mfw78 requested review from anxolin and a team January 23, 2024 08:11
anxolin
anxolin approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 sound good to me

@mfw78 mfw78 self-assigned this Jan 25, 2024
@mfw78 mfw78 merged commit b9bf2a9 into main Jan 25, 2024
4 checks passed
@mfw78 mfw78 deleted the metrics-imports branch January 25, 2024 08:11
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

@alfetopito alfetopito alfetopito approved these changes

Assignees

@mfw78 mfw78

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfw78 @alfetopito @anxolin