Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: jsonrpc and websockets #150

Merged
merged 1 commit into from
Apr 3, 2024
Merged

feat: jsonrpc and websockets #150

merged 1 commit into from
Apr 3, 2024

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented Apr 2, 2024

Description

Adds support again for JSON-RPC now that infrastructure has been updated and no longer has whacky state inconsistencies.

Changes

  • Automatically determine whether to use WebSockets or JsonRpcProvider

How to test

  1. Configure with JSON RPC provider, confirm starts.
  2. Configure with websockets provider, confirm starts.

Related Issues

Fixes #138

@mfw78 mfw78 added the enhancement New feature or request label Apr 2, 2024
@mfw78 mfw78 requested review from anxolin and a team April 2, 2024 11:16
@mfw78 mfw78 self-assigned this Apr 2, 2024
anxolin
anxolin approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thanks

@mfw78 mfw78 merged commit 4f86cb4 into main Apr 3, 2024
4 checks passed
@mfw78 mfw78 deleted the jsonrpc-and-websockets branch April 3, 2024 11:48
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

@alfetopito alfetopito alfetopito approved these changes

Assignees

@mfw78 mfw78

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: support json rpc provider
3 participants
@mfw78 @alfetopito @anxolin