Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an attempt to improve the first sync for watch-tower
Context: Before this PR
The issue with the current model is that
The issues we experience is becasue between 2 and 3 there's a delay and the metric of "blocks processed" goes down. Thats our main metric.
The solution is to not make a plan and process blocks as we find them instead of waiting to be fully catched up.
Proposed solution
I just refactored the 2 points where we do the processing of blocks (applying the plan, and when watching for new blocks).
Now I use an auxiliary function that will process the block, update the metrics, and persist in the database.
This should help in several ways:
Test
I haven't tested this much and is very sensitive change. I would love to get some feedback first, then I'd like to test it in staging.
I just did a minimal test of running it in Arbitrum locally:
The watch-tower arrived to a SYNC state and processed blocks as it found them: