-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: health probe #96
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfw78
added
infra
Infra, devops, CI and related tasks
E:1.2: Watch Tower Service
https://github.com/cowprotocol/pm/issues/8
labels
Oct 6, 2023
alfetopito
reviewed
Oct 6, 2023
anxolin
reviewed
Oct 6, 2023
mfw78
force-pushed
the
chore-metrics
branch
3 times, most recently
from
October 7, 2023 03:41
7e80376
to
e7b3d4e
Compare
Closed
2 tasks
alfetopito
approved these changes
Oct 9, 2023
anxolin
reviewed
Oct 9, 2023
anxolin
reviewed
Oct 9, 2023
anxolin
reviewed
Oct 9, 2023
); | ||
if (isRunningInKubernetesPod()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why mentioning here Kubernetes?
I think this could just be a setting: exit on stale chain state
this.sync = ChainSync.STALE;
if (exitOnStaleChainState) {
await registry.storage.close();
exit(1)
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
E:1.2: Watch Tower Service
https://github.com/cowprotocol/pm/issues/8
enhancement
New feature or request
infra
Infra, devops, CI and related tasks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides overall health monitoring for the block watcher (chain contexts). This assists with Kubernetes deployment to enable health probes for automatic restarting and monitoring.
Changes
/health
API endpoint, returning >= 400 when the chain is not synced (in warm-up).How to test
/health
API endpoint returns500
status error, with JSON showing current chain context status./health
API endpoint returns200
status with JSON showing the current chain status.Related Issues
Fixes #70