Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Merge Chat and Workflow Iterator into a generic Stream Iterator #32

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

chyroc
Copy link
Collaborator

@chyroc chyroc commented Sep 28, 2024

  • Merged ChatChatIterator and WorkflowIterator into a single generic Stream Iterator
  • Unified iterator to support both Chat and Workflow module

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 67.14286% with 23 lines in your changes missing coverage. Please review.

Project coverage is 76.51%. Comparing base (23a6785) to head (632e688).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
cozepy/workflows/runs/__init__.py 17.64% 14 Missing ⚠️
tests/test_workflow.py 20.00% 4 Missing ⚠️
cozepy/chat/__init__.py 81.25% 3 Missing ⚠️
cozepy/model.py 93.33% 2 Missing ⚠️
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   74.80%   76.51%   +1.70%     
==========================================
  Files          30       30              
  Lines        1028     1009      -19     
==========================================
+ Hits          769      772       +3     
+ Misses        259      237      -22     
Flag Coverage Δ
76.51% <67.14%> (+1.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cozepy/__init__.py 100.00% <ø> (ø)
tests/test_chat.py 100.00% <100.00%> (ø)
cozepy/model.py 78.12% <93.33%> (+11.45%) ⬆️
cozepy/chat/__init__.py 84.73% <81.25%> (-0.24%) ⬇️
tests/test_workflow.py 25.00% <20.00%> (ø)
cozepy/workflows/runs/__init__.py 62.50% <17.64%> (+13.06%) ⬆️

@chyroc chyroc merged commit bc868be into main Sep 28, 2024
11 of 12 checks passed
@chyroc chyroc deleted the refactor-stream-iterator branch September 28, 2024 15:19
@chyroc chyroc added the feature label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant