-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add setTheme to custum cozy bar design #451
Conversation
Instead of
Shouldn't we have something like :
? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but need more tests to be great 👍
@@ -0,0 +1,5 @@ | |||
<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je pense que c'est problématique d'avoir les SVG avec de la couleur on devrait pouvoir avoir la même SVG pour les 2 themes. Mais c'est à voir dans de l'optimisation dans un futur plus ou moins proche...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try to use the fill
css property? Or maybe a SVGr component like for Home icon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more complex because we used it on background-image.
With my comment I wanted to warn you but not necessarily solve the problem in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can avoid using it as a background-image? Did you try it?
This issue should be solved in this PR instead of keeping it in the code for a while IMHO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CPatchane I used an Icon
from cozy-ui instead of the background-image svg. Is it OK for you like this?
🎉 This PR is included in version 6.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Change theme bar
It's possible to update design on the cozy-bar with
setTheme
function.This feature impact only mobile version.