Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cozy client migration #1979

Merged
merged 32 commits into from
Jun 9, 2020
Merged

Cozy client migration #1979

merged 32 commits into from
Jun 9, 2020

Conversation

y-lohse
Copy link
Contributor

@y-lohse y-lohse commented Mar 19, 2020

We would like to start testing the new view using cozy-client, so I'd like to merge this. Most of the code is still a work in progress so I'm not sure how much sense a review makes at this point. Everything new is behind a flag, the old routes should be untouched.

@y-lohse y-lohse requested a review from Crash-- March 19, 2020 15:06
@y-lohse y-lohse self-assigned this Mar 19, 2020
@y-lohse y-lohse force-pushed the cozy-client branch 3 times, most recently from a117ca3 to 6133190 Compare March 20, 2020 10:36
@y-lohse y-lohse requested a review from ptbrowne as a code owner May 20, 2020 08:22

if (modalStack.length === 0) return null
else return modalStack[modalStack.length - 1]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiens, ca ressemble à la ModalStack dans cozy-ui non ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui, je me suis dit la meme chose en l'écrivant. Il y a surement quelque chose à mutualiser a ce niveau la.

@y-lohse
Copy link
Contributor Author

y-lohse commented Jun 8, 2020

This PR is ready for review. Just to be clear, not everything in there is finished, but we would like to merge what is already there so we can work on the same codebase and so that other people can start testing the new view. So the review is more about identifying any red flags than a defitinitive code review.

  • Changes to existing files should be fairly small: it's either splitting up components into multiple files, or exporting tweaked versions of existing components. There should be no breaking changes in existing files.
  • There are new fIles for the view using cozy-client. Most of them are in src/drive/web/view/Drive. I think it's a good time for feedback about the general architecture. On the other hand, this code still needs tests, and may be moved around (for example all the pure logic code in useActions.jsx) in future PRs.

@ptbrowne
Copy link
Contributor

ptbrowne commented Jun 8, 2020

Thanks for all the explanations in video. LGTM and we continue to work on this on other PRs.

@y-lohse y-lohse merged commit 9294819 into master Jun 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the cozy-client branch June 9, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants