-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cozy client migration #1979
Cozy client migration #1979
Conversation
a117ca3
to
6133190
Compare
|
||
if (modalStack.length === 0) return null | ||
else return modalStack[modalStack.length - 1] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiens, ca ressemble à la ModalStack dans cozy-ui non ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oui, je me suis dit la meme chose en l'écrivant. Il y a surement quelque chose à mutualiser a ce niveau la.
This PR is ready for review. Just to be clear, not everything in there is finished, but we would like to merge what is already there so we can work on the same codebase and so that other people can start testing the new view. So the review is more about identifying any red flags than a defitinitive code review.
|
Thanks for all the explanations in video. LGTM and we continue to work on this on other PRs. |
We would like to start testing the new view using cozy-client, so I'd like to merge this. Most of the code is still a work in progress so I'm not sure how much sense a review makes at this point. Everything new is behind a flag, the old routes should be untouched.