Public view fixes #2021
Merged
Public view fixes #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crash--
reviewed
May 25, 2020
| mapStateToProps, | ||
| mapDispatchToProps | ||
| )(LightFileList) | ||
| ) |
There was a problem hiding this comment.
I don't understand this change. It seems we don't use router in this component and we don't pass it neither to its children. Can you explain why this is needed?
There was a problem hiding this comment.
It is used here, in the mapDispatchToProps of he component. But I agree, it's not very obvious. Do you think it would be better to include the Actions file in this one to make it more explicit? Otherwise we can add a comment imo.
There was a problem hiding this comment.
The best solution is to not rely on ownprops.something (since it can be dangerous for the perf) but I don't know how to handle that.
src/drive/web/modules/drive/Toolbar/components/ShortcutCreationModal.spec.jsx
Show resolved
Hide resolved
Lost during rebasing
Allows to use waitFor from react-testing-library
Crash--
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebasing #2017 was not straightforward and it appears I did loose a few changes in the process.
See individual commit messages for details.