Add Only Office Toolbar #2324
Merged
Add Only Office Toolbar #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JF-Cozy
force-pushed
the
feat/ooToolbar
branch
8 times, most recently
from
8ffe1be to
ef7eb8a
Compare
Crash--
reviewed
May 4, 2021
Crash--
reviewed
May 4, 2021
Crash--
reviewed
May 4, 2021
Crash--
reviewed
May 4, 2021
Crash--
reviewed
May 4, 2021
Crash--
reviewed
May 4, 2021
Crash--
reviewed
May 4, 2021
Crash--
reviewed
May 4, 2021
Crash--
reviewed
May 4, 2021
src/drive/web/modules/views/OnlyOffice/Toolbar/useFileWithPath.jsx
Outdated
Show resolved
Hide resolved
Crash--
reviewed
May 4, 2021
Crash--
reviewed
May 4, 2021
Crash--
reviewed
May 4, 2021
Crash--
reviewed
May 4, 2021
Crash--
reviewed
May 4, 2021
Crash--
reviewed
May 4, 2021
JF-Cozy
force-pushed
the
feat/ooToolbar
branch
2 times, most recently
from
47b682c to
6646e81
Compare
JF-Cozy
force-pushed
the
feat/ooToolbar
branch
3 times, most recently
from
85f6047 to
258cbbf
Compare
Needed because of two things about useFilesQueryWithPath - it doesn't allow passing only one file as argument - it use a getByIds() query, not allowed by the stack in public view
Useful to avoid passing props throw children. isReadOnly is set only after getting configuration from the stack fileId and isPublic are get from the router All are used in the Toolbar
and refactor config creation in useConfig
Crash--
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajout de la toolbar pour only office en partie privée + partie publique en partage par lien.
Le partage cozy à cozy n'est pas concerné ici (pour une prochaine PR), et n'est pas nécessairement fonctionnel. Comme il y a un feature flag et que OnlyOffice doit être activé sur le serveur, ce n'est pas un souci.
Au lieu de passer les props
fileIdetisReadOnlyd'enfant à enfant j'ai plutôt utilisé un contexte.Desktop
Mobile
Public Desktop
Public Mobile
