Avoid errors on backup page on old flagship app #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zatteo
commented
Sep 29, 2023
zatteo
commented
BundleMonUnchanged files (19)
No change in files bundle size Unchanged groups (8)
Final result: ✅ View report in BundleMon website ➡️ |
Crash--
approved these changes
Sep 29, 2023
cballevre
reviewed
Sep 29, 2023
| import LastBackupStatus from './components/LastBackupStatus' | ||
| import AllowPermissionsModal from './components/AllowPermissionsModal' | ||
| import { BackupError } from './components/BackupError' | ||
|
|
||
| import { BackupActionsProvider } from 'photos/ducks/backup/hooks/useBackupActions' | ||
| import { isFlagshipApp } from 'cozy-device-helper' | ||
|
|
||
| const BackupPage = () => { | ||
| const BackupPageContent = () => { |
There was a problem hiding this comment.
nit: Extract this component into a separate file
There was a problem hiding this comment.
This component will be used only here so I prefer to keep it here.
cballevre
reviewed
Sep 29, 2023
cballevre
approved these changes
Sep 29, 2023
A window.cozy.backup_available flag was sent by the flagship app but not used. So errors were shown because intent were not available on old flagship app version.
zatteo
force-pushed
the
feat/manage-better
branch
from
589896b to
eaa79ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.