-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make working back button for a file at another Cozy #2999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cballevre
force-pushed
the
feat/office-back-with-redirect-link
branch
from
October 9, 2023 07:27
de466c9
to
dda671b
Compare
BundleMonFiles updated (5)
Unchanged files (14)
Total files change +118.32KB +2.6% Groups updated (5)
Unchanged groups (3)
Final result: ✅ View report in BundleMon website ➡️ |
Crash--
reviewed
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? Can we add a bit more of context please?
Crash--
reviewed
Oct 9, 2023
return ( | ||
<IconButton | ||
data-testid="onlyoffice-backButton" | ||
className="u-ml-half-s" | ||
onClick={onClick} | ||
size="medium" | ||
aria-label={t('button.back')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
Crash--
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Historically, we were going backwards in the browser's history for 3 reasons:
Why did we decide to use redirectLink instead of jumping to the browser history?
To get around the problem of whether or not the url is shared in the search parameters, we use the
/permission/self
request in the stack as it is included with who the file is shared with. Each person in a share has a unique link, so there is only one person included.