Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OnlyOffice): Regression from migration react-route to v6 #3001

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

cballevre
Copy link
Contributor

@cballevre cballevre commented Oct 10, 2023

In react-router v6, we need an <outlet /> instead of a children otherwise the subroute like paywall would no longer be displayed

### 🐛 Bug Fixes

* Display the OnlyOffice paywall when there are no editing rights

In react-router v6, we need an <outlet /> instead of a children otherwise the subroute like paywall would no longer be displayed
@cballevre cballevre requested review from Crash-- and zatteo October 10, 2023 07:48
Copy link
Contributor

@Crash-- Crash-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you say so

@bundlemon
Copy link

bundlemon bot commented Oct 10, 2023

BundleMon

Unchanged files (19)
Status Path Size Limits
drive/public/drive.(hash).js
1.59MB 1.65MB
drive/vendors/drive.(hash).js
1.36MB 1.6MB
drive/public/pdf.worker.entry.(hash).worker.j
s
343.37KB 345KB
drive/app/drive.(hash).js
269.65KB 280KB
drive/services/dacc/drive.js
254.52KB 500KB
drive/services/qualificationMigration/drive.j
s
249.66KB 500KB
drive/intents/drive.(hash).js
162.42KB 171KB
drive/public/cozy-client-js.js
158.97KB 160KB
drive/public/drive.(hash).min.css
92.6KB 100KB
drive/app-drive.(hash).min.css
55.72KB 56KB
drive/intents-drive.(hash).min.css
37.06KB 40KB
drive/onlyOffice/slide.pptx
24.82KB 25KB
drive/onlyOffice/text.docx
5.84KB 6KB
drive/onlyOffice/spreadsheet.xlsx
5.01KB 6KB
drive/manifest.webapp
1.77KB 2KB
drive/index.html
528B 1KB
drive/intents/index.html
515B 1KB
drive/img/app-icon.(hash).svg
419B 1KB
drive/manifest.json
184B 1KB

Total files change +13B 0%

Unchanged groups (8)
Status Path Size Limits
drive/public/**
2.18MB +7%
drive/screenshots/**
2.13MB +0.4%
drive/vendors/**
1.36MB +6%
drive/services/**
504.18KB +1%
drive/app/**
269.65KB +10%
drive/intents/**
162.92KB +6%
drive/onlyOffice/**
35.68KB +0.4%
drive/img/**
419B +0.4%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@cballevre cballevre merged commit 639322d into master Oct 10, 2023
3 checks passed
@cballevre cballevre deleted the fix/onlyoffice-paywall branch October 10, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants