Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send all files to upload at once #3004

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

acezard
Copy link
Contributor

@acezard acezard commented Oct 23, 2023

✨ Features

  • When uploading files from flagship, send the list in one message

Fixed issues :

  • The CI was not succeeding in reading the babel config from babel-preset-cozy-app. We had to add it explicitly
  • During debugging we also had to update multiple libraries related to testing, and updated configurations accordingly
  • Cozy-scripts was giving issues during testing for now we used jest directly in the test command, like it is done on some other cozy apps

@acezard acezard force-pushed the feat--send-all-files-to-upload-at-once branch 2 times, most recently from 0e96961 to 1f27634 Compare October 23, 2023 09:56
@acezard acezard force-pushed the feat--send-all-files-to-upload-at-once branch from 6f791f6 to 317f905 Compare October 23, 2023 12:17
@bundlemon
Copy link

bundlemon bot commented Oct 23, 2023

BundleMon

Files updated (10)
Status Path Size Limits
drive/public/drive.(hash).js
1.54MB (+5KB +0.32%) 1.65MB
drive/app/drive.(hash).js
273.97KB (+2.67KB +0.98%) 280KB
drive/vendors/drive.(hash).js
1.31MB (+2.09KB +0.16%) 1.6MB
drive/services/dacc/drive.js
256.87KB (+341B +0.13%) 500KB
drive/intents/drive.(hash).js
164.43KB (+191B +0.11%) 171KB
drive/services/qualificationMigration/drive.j
s
251.46KB (+176B +0.07%) 500KB
drive/manifest.webapp
1.88KB (+114B +6.28%) 2KB
drive/intents-drive.(hash).min.css
36.92KB (-140B -0.37%) 40KB
drive/app-drive.(hash).min.css
55.52KB (-199B -0.35%) 56KB
drive/public/drive.(hash).min.css
92.4KB (-208B -0.22%) 100KB
Unchanged files (9)
Status Path Size Limits
drive/public/pdf.worker.entry.(hash).worker.j
s
343.37KB 345KB
drive/public/cozy-client-js.js
158.97KB 160KB
drive/onlyOffice/slide.pptx
24.82KB 25KB
drive/onlyOffice/text.docx
5.84KB 6KB
drive/onlyOffice/spreadsheet.xlsx
5.01KB 6KB
drive/index.html
529B 1KB
drive/intents/index.html
515B 1KB
drive/img/app-icon.(hash).svg
419B 1KB
drive/manifest.json
184B 1KB

Total files change +10.02KB +0.22%

Groups updated (5)
Status Path Size Limits
drive/public/**
2.13MB (+4.79KB +0.22%) +7%
drive/app/**
273.97KB (+2.67KB +0.98%) +10%
drive/vendors/**
1.31MB (+2.09KB +0.16%) +6%
drive/services/**
508.33KB (+517B +0.1%) +1%
drive/intents/**
164.93KB (+191B +0.11%) +6%
Unchanged groups (3)
Status Path Size Limits
drive/screenshots/**
2.13MB +0.4%
drive/onlyOffice/**
35.68KB +0.4%
drive/img/**
419B +0.4%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

- Add preset because CI fails to read it from the dependency
- Fix a test
- Fix a jest transformIgnorePattern
@acezard acezard force-pushed the feat--send-all-files-to-upload-at-once branch from 1efed9a to f553a85 Compare October 23, 2023 14:32
@acezard acezard merged commit f832b7f into master Oct 23, 2023
3 checks passed
@acezard acezard deleted the feat--send-all-files-to-upload-at-once branch October 23, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants