fix: Harmonize flagship upload view #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles updated (3)
Unchanged files (16)
Total files change +378B +0.01% Groups updated (3)
Unchanged groups (5)
Final result: ✅ View report in BundleMon website ➡️ |
acezard
force-pushed
the
fix--Harmonize-flagship-upload-view-with-other-views
branch
2 times, most recently
from
730f732 to
53ad7f4
Compare
- file icon - no back arrow - fix paddings - fix breadcrumb overlay
acezard
force-pushed
the
fix--Harmonize-flagship-upload-view-with-other-views
branch
from
53ad7f4 to
8fb8a54
Compare
Ldoppea
approved these changes
Oct 26, 2023
| // The upload can only happen once as the webapp is closed before the upload process can start again | ||
| if (didFlow.current) return | ||
|
|
||
| const processed = (getProcessed(state) as () => unknown[]).length |
There was a problem hiding this comment.
This typing seems weird. Shouldn't this be getProcesses(state) as unknown[]? Otherwise you seems to call .length on a method pointer.
There was a problem hiding this comment.
that's because I'm casting the actual getProcessed selector instead of the result, in any case it doesn't look great when using untyped code in strictly typed code
| @@ -18,7 +18,8 @@ declare module 'cozy-ui/transpiled/react/providers/I18n' { | |||
|
|
|||
| declare module 'cozy-ui/transpiled/react/deprecated/Alerter' { | |||
| const Alerter: { | |||
| error: (message: string) => void | |||
| error: (message: string, options?: Record<string, unknown>) => void | |||
| success: (message: string, options?: Record<string, unknown>) => void | |||
There was a problem hiding this comment.
Should we modify cozy-ui to expose those new definitions?
There was a problem hiding this comment.
yes ideally, in this case I took the fastest way, I think it can be done after publication in test flight (for flagship too)
| @@ -533,6 +533,7 @@ | |||
| "header": "Uploading %{smart_count} photo to Cozy Drive |||| Uploading %{smart_count} photos to Cozy Drive", | |||
| "header_mobile": "Uploading %{done} of %{total}", | |||
| "header_done": "Uploaded %{done} out of %{total} successfully", | |||
| "success_flagship": "%{smart_count} file uploaded with success. |||| %{smart_count} files uploaded with success.", | |||
There was a problem hiding this comment.
Don't forget to add other languages translations
There was a problem hiding this comment.
Going to do that in Transifex 👍
acezard
deleted the
fix--Harmonize-flagship-upload-view-with-other-views
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fixes