mockResponse - tests to verify write() and end() with payloads
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Declare a new getter `_getChunks`, for testing purposes * Add javadoc for `_getBuffer` * Add a suite of tests that ensure that calls to `write` and `end` with payloads result in the correct state of `_data`, `_chunks` and `_buffer`. Ensure that methods are tested in isolation, using a separate suite for interactions between `write` and `end`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_getChunks, for testing purposes_getBufferwriteandendwith payloadsresult in the correct state of
_data,_chunksand_buffer. Ensure that methodsare tested in isolation, using a separate suite for interactions between
writeandendeugef#161 also filed in the event that this PR is not merged into the proposed branch (which for the benefit of other readers is the branch for eugef#154)