Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is the milliseconds component required for timecodes? #24

Closed
tennety opened this issue May 18, 2017 · 0 comments
Closed

Is the milliseconds component required for timecodes? #24

tennety opened this issue May 18, 2017 · 0 comments

Comments

@tennety
Copy link
Contributor

tennety commented May 18, 2017

This is less of an issue and more of a clarifying question. I have a working SRT file (from mediaelementjs.com) which has timecodes in this format:

0
00:00:00,1 --> 00:00:04
HTML5 <video> and <audio> was supposed to be awesome, powerful, and fun.

1
00:00:04 --> 00:00:07
But browser vendors couldn't agree on a codec

This is marked invalid by SRT::File.parse because the timecodes don't have a ms component. I couldn't find anything in terms of a spec that clarifies this, so asking here! I'll be happy to submit a PR that makes it optional.
tennety added a commit to instructure/srt that referenced this issue May 18, 2017
@tennety
Allows timecode format hh:mm:ss to be valid (cpetersen#24)
68484ef
tennety added a commit to instructure/srt that referenced this issue May 18, 2017
@tennety
Merge pull request #1 from instructure/td-2373-optional-ms
147ddf9 
Allows timecode format hh:mm:ss to be valid (cpetersen#24)
cpetersen added a commit that referenced this issue May 22, 2017
@cpetersen
Merge pull request #25 from instructure/td-2373-optional-ms
69611ad 
Allows timecode format hh:mm:ss to be valid (#24)
@tennety tennety closed this as completed May 23, 2017
@warren-bank warren-bank mentioned this issue Mar 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tennety