Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to reusable workflows #194

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Switch to reusable workflows #194

merged 5 commits into from
Feb 21, 2024

Conversation

shenxianpeng
Copy link
Collaborator

@shenxianpeng shenxianpeng commented Feb 20, 2024 •
edited
Loading

@shenxianpeng shenxianpeng added the enhancement New feature or request label Feb 20, 2024
@shenxianpeng shenxianpeng requested a review from 2bndy5 February 21, 2024 08:22
@shenxianpeng shenxianpeng marked this pull request as ready for review February 21, 2024 08:22
2bndy5
2bndy5 requested changes Feb 21, 2024
View reviewed changes
.github/workflows/mkdocs-deploy.yml Outdated Show resolved Hide resolved
@shenxianpeng
Copy link
Collaborator Author

I just call reusable workflows from cpp-linter/.github/.github/workflows, not sure if combining these there workflows into one workflow named main.yml is a good idea or not.

@2bndy5
Copy link
Collaborator

2bndy5 commented Feb 21, 2024

I just call reusable workflows from cpp-linter/.github/.github/workflows, not sure if combining these there workflows into one workflow named main.yml is a good idea or not.

That's not what I meant.

    uses: cpp-linter/.github/.github/workflows/mkdocs.yml@reusable-workflows

This calls the reusable workflow (yml file) from .github repo's reusable-workflows branch.

    uses: cpp-linter/.github/.github/workflows/mkdocs.yml@main

This calls the reusable workflow (yml file) from .github repo's main branch.

@shenxianpeng
Copy link
Collaborator Author

I mean after calling reusable workflows from cpp-linter/.github/.github/workflows in this PR, I changed 3 workflows.
Wouldn't it be better if these 3 workflows were combined into 1 workflow? Probably not recommended.

@2bndy5
Copy link
Collaborator

2bndy5 commented Feb 21, 2024

I mean after calling reusable workflows from cpp-linter/.github/.github/workflows in this PR, I changed 3 workflows. Wouldn't it be better if these 3 workflows were combined into 1 workflow? Probably not recommended.

No, that is too totalitarian. What you have no now is much more flexible.

@shenxianpeng shenxianpeng merged commit d193a5a into main Feb 21, 2024
32 checks passed
@shenxianpeng shenxianpeng deleted the reusable-workflows branch February 21, 2024 08:49
@shenxianpeng shenxianpeng changed the title Refactor existing workflows to use reusable workflows Switch to reusable workflows Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2bndy5 2bndy5 2bndy5 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shenxianpeng @2bndy5