Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump clang-tools from 0.12.1 to 0.13.0 in the pip group #47

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 10, 2024

Bumps the pip group with 1 update: clang-tools.

Updates clang-tools from 0.12.1 to 0.13.0

Release notes

Sourced from clang-tools's releases.

v0.13.0

🚀 New features and improvements

🐛 Bug fixes

📦 Dependency updates

Full Changelog: cpp-linter/clang-tools-pip@v0.12.1...v0.13.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the pip group with 1 update: [clang-tools](https://github.com/cpp-linter/clang-tools-pip).


Updates `clang-tools` from 0.12.1 to 0.13.0
- [Release notes](https://github.com/cpp-linter/clang-tools-pip/releases)
- [Commits](cpp-linter/clang-tools-pip@v0.12.1...v0.13.0)

---
updated-dependencies:
- dependency-name: clang-tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: pip
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file minor A minor version bump python Pull requests that update Python code labels Jun 10, 2024
Copy link
Collaborator

@shenxianpeng shenxianpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix test failure

@shenxianpeng
Copy link
Collaborator

Hi @2bndy5 I think this PR cpp-linter/clang-tools-pip#95 changes the previous behavior when the user passes --version in the .pre-commit-config.yaml file. do you have any suggestions about it?

repos:
  - repo: https://github.com/cpp-linter/cpp-linter-hooks
    rev: v0.4.0
    hooks:
      - id: clang-format
        args: [--style=file, --version=16] # Specifies version
      - id: clang-tidy
        args: [--checks=.clang-tidy, --version=16]  # Specifies version

@2bndy5
Copy link
Contributor

2bndy5 commented Jun 21, 2024

From the test CI I see the error

AttributeError: 'str' object has no attribute 'info'

about the following function

def is_installed(tool_name: str, version: str) -> Optional[Path]:

The given version must be parsed before passing it to clang_tools.install.is_installed().

from clang_tools.util import Version
from clang_tools.install import is_installed as _is_installed

# let version_in be the user-input version (as a string)
parsed_ver = Version(version_in)
path = _is_installed(tool_name, parsed_ver)

So, here needs to be updated:

path = _is_installed(tool_name, version)

There might be other places too. I'm not that familiar with the code here.

@shenxianpeng shenxianpeng force-pushed the dependabot/pip/pip-23fe1d33e3 branch from 4b4a92e to 343ce83 Compare June 21, 2024 05:14
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.71%. Comparing base (d3159c2) to head (4b4a92e).

Current head 4b4a92e differs from pull request most recent head 343ce83

Please upload reports for the commit 343ce83 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   85.33%   85.71%   +0.38%     
==========================================
  Files           3        3              
  Lines          75       77       +2     
==========================================
+ Hits           64       66       +2     
  Misses         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jun 21, 2024

@shenxianpeng
Copy link
Collaborator

Thanks @2bndy5. The CI error has been fixed.

@shenxianpeng shenxianpeng self-requested a review June 21, 2024 05:15
@shenxianpeng shenxianpeng merged commit 04b9a17 into main Jun 21, 2024
6 checks passed
@shenxianpeng shenxianpeng deleted the dependabot/pip/pip-23fe1d33e3 branch June 21, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file minor A minor version bump python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants