-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump clang-tools from 0.12.1 to 0.13.0 in the pip group #47
Conversation
Bumps the pip group with 1 update: [clang-tools](https://github.com/cpp-linter/clang-tools-pip). Updates `clang-tools` from 0.12.1 to 0.13.0 - [Release notes](https://github.com/cpp-linter/clang-tools-pip/releases) - [Commits](cpp-linter/clang-tools-pip@v0.12.1...v0.13.0) --- updated-dependencies: - dependency-name: clang-tools dependency-type: direct:production update-type: version-update:semver-minor dependency-group: pip ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix test failure
Hi @2bndy5 I think this PR cpp-linter/clang-tools-pip#95 changes the previous behavior when the user passes repos:
- repo: https://github.com/cpp-linter/cpp-linter-hooks
rev: v0.4.0
hooks:
- id: clang-format
args: [--style=file, --version=16] # Specifies version
- id: clang-tidy
args: [--checks=.clang-tidy, --version=16] # Specifies version |
From the test CI I see the error
about the following function cpp-linter-hooks/cpp_linter_hooks/util.py Line 15 in d3159c2
The given version must be parsed before passing it to from clang_tools.util import Version
from clang_tools.install import is_installed as _is_installed
# let version_in be the user-input version (as a string)
parsed_ver = Version(version_in)
path = _is_installed(tool_name, parsed_ver) So, here needs to be updated: cpp-linter-hooks/cpp_linter_hooks/util.py Line 27 in d3159c2
There might be other places too. I'm not that familiar with the code here. |
4b4a92e
to
343ce83
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 85.33% 85.71% +0.38%
==========================================
Files 3 3
Lines 75 77 +2
==========================================
+ Hits 64 66 +2
Misses 11 11 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Thanks @2bndy5. The CI error has been fixed. |
Bumps the pip group with 1 update: clang-tools.
Updates
clang-tools
from 0.12.1 to 0.13.0Release notes
Sourced from clang-tools's releases.
Commits
7d78b27
Bump cpp-linter/clang-tools-static-binaries to master-2e4f8c1f (#100)8d5f32b
allow version to be a path (#95)b93b1da
Switch toactions/stale
(#93)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions