Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add possibility to used ANTs non linear registration #100

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Dec 16, 2022

closes #61
closes #55

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 16, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.16%.

Quality metrics Before After Change
Complexity 3.37 ⭐ 3.29 ⭐ -0.08 👍
Method Length 63.13 🙂 62.45 🙂 -0.68 👍
Working memory 5.87 ⭐ 5.85 ⭐ -0.02 👍
Quality 76.03% 76.19% 0.16% 👍
Other metrics Before After Change
Lines 1210 1269 59
Changed files Quality Before Quality After Quality Change
bidsmreye/bidsmreye.py 57.82% 🙂 59.51% 🙂 1.69% 👍
bidsmreye/prepare_data.py 66.79% 🙂 64.46% 🙂 -2.33% 👎
bidsmreye/utils.py 74.78% 🙂 75.13% ⭐ 0.35% 👍
tests/test_bidsmreye.py 92.21% ⭐ 91.92% ⭐ -0.29% 👎
tests/test_utils.py 92.71% ⭐ 92.72% ⭐ 0.01% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
bidsmreye/bidsmreye.py cli 16 🙂 248 ⛔ 10 😞 40.51% 😞 Try splitting into smaller methods. Extract out complex expressions
bidsmreye/utils.py Config.check_argument 11 🙂 177 😞 9 🙂 51.74% 🙂 Try splitting into smaller methods
bidsmreye/utils.py Config.__attrs_post_init__ 9 🙂 214 ⛔ 7 🙂 55.23% 🙂 Try splitting into smaller methods
bidsmreye/utils.py check_layout 9 🙂 148 😞 9 🙂 56.40% 🙂 Try splitting into smaller methods
bidsmreye/prepare_data.py process_subject 2 ⭐ 192 😞 8 🙂 61.30% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Remi-Gau Remi-Gau changed the title [ENH] add possibility to used ATNs non linear registration [ENH] add possibility to used ANTs non linear registration Dec 16, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.45%. Comparing base (f4f69b1) to head (001c90c).
Report is 172 commits behind head on main.

Files with missing lines Patch % Lines
bidsmreye/prepare_data.py 28.57% 5 Missing ⚠️
bidsmreye/bidsmreye.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   65.17%   65.45%   +0.27%     
==========================================
  Files           7        7              
  Lines         560      576      +16     
  Branches       85       88       +3     
==========================================
+ Hits          365      377      +12     
- Misses        163      167       +4     
  Partials       32       32              
Flag Coverage Δ
tests 65.45% <75.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau merged commit 3581585 into cpp-lln-lab:main Dec 16, 2022
@Remi-Gau Remi-Gau deleted the ants_arg branch December 16, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add arguments to improve alignment of prepare data update contributing.md
1 participant