Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add basic QC #102

Merged
merged 19 commits into from
Dec 17, 2022
Merged

[ENH] add basic QC #102

merged 19 commits into from
Dec 17, 2022

Conversation

Remi-Gau
Copy link
Contributor

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 16, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 2.03%.

Quality metrics Before After Change
Complexity 3.50 ⭐ 3.18 ⭐ -0.32 👍
Method Length 74.60 🙂 72.40 🙂 -2.20 👍
Working memory 7.02 🙂 6.75 🙂 -0.27 👍
Quality 71.61% 🙂 73.64% 🙂 2.03% 👍
Other metrics Before After Change
Lines 1029 1039 10
Changed files Quality Before Quality After Quality Change
bidsmreye/generalize.py 64.54% 🙂 66.72% 🙂 2.18% 👍
bidsmreye/prepare_data.py 64.46% 🙂 68.35% 🙂 3.89% 👍
bidsmreye/utils.py 75.13% ⭐ 76.08% ⭐ 0.95% 👍
tests/test_generalize.py 90.60% ⭐ 85.83% ⭐ -4.77% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
bidsmreye/generalize.py process_subject 4 ⭐ 216 ⛔ 12 😞 49.66% 😞 Try splitting into smaller methods. Extract out complex expressions
bidsmreye/utils.py Config.check_argument 11 🙂 177 😞 9 🙂 51.74% 🙂 Try splitting into smaller methods
bidsmreye/utils.py Config.__attrs_post_init__ 9 🙂 214 ⛔ 7 🙂 55.23% 🙂 Try splitting into smaller methods
bidsmreye/utils.py check_layout 9 🙂 148 😞 9 🙂 56.40% 🙂 Try splitting into smaller methods
bidsmreye/prepare_data.py combine_data_with_empty_labels 0 ⭐ 165 😞 9 🙂 63.46% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Attention: Patch coverage is 88.08511% with 28 lines in your changes missing coverage. Please review.

Project coverage is 75.00%. Comparing base (001c90c) to head (cce6495).
Report is 169 commits behind head on main.

Files with missing lines Patch % Lines
bidsmreye/utils.py 57.14% 8 Missing and 1 partial ⚠️
bidsmreye/prepare_data.py 42.85% 8 Missing ⚠️
bidsmreye/quality_control.py 94.21% 3 Missing and 4 partials ⚠️
bidsmreye/generalize.py 75.00% 3 Missing ⚠️
bidsmreye/visualize.py 98.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   65.45%   75.00%   +9.54%     
==========================================
  Files           7        9       +2     
  Lines         576      776     +200     
  Branches       88      104      +16     
==========================================
+ Hits          377      582     +205     
+ Misses        167      151      -16     
- Partials       32       43      +11     
Flag Coverage Δ
tests 74.87% <87.65%> (+9.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau merged commit 11fb41b into cpp-lln-lab:main Dec 17, 2022
@Remi-Gau Remi-Gau deleted the ants_arg branch December 17, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant