Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] save one output per subject #26

Merged
merged 7 commits into from
Jul 21, 2022
Merged

[ENH] save one output per subject #26

merged 7 commits into from
Jul 21, 2022

Conversation

Remi-Gau
Copy link
Contributor

closes #23

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 21, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.19%.

Quality metrics Before After Change
Complexity 3.11 ⭐ 2.88 ⭐ -0.23 👍
Method Length 59.38 ⭐ 59.76 ⭐ 0.38 👎
Working memory 9.23 🙂 9.47 🙂 0.24 👎
Quality 69.17% 🙂 69.36% 🙂 0.19% 👍
Other metrics Before After Change
Lines 788 770 -18
Changed files Quality Before Quality After Quality Change
bidsmreye/bidsutils.py 81.50% ⭐ 81.78% ⭐ 0.28% 👍
bidsmreye/combine.py 67.28% 🙂 66.79% 🙂 -0.49% 👎
bidsmreye/generalize.py 47.51% 😞 52.60% 🙂 5.09% 👍
bidsmreye/prepare_data.py 69.63% 🙂 71.60% 🙂 1.97% 👍
bidsmreye/run.py 37.33% 😞 40.22% 😞 2.89% 👍
bidsmreye/utils.py 87.19% ⭐ 86.13% ⭐ -1.06% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
bidsmreye/generalize.py generalize 3 ⭐ 223 ⛔ 17 ⛔ 43.84% 😞 Try splitting into smaller methods. Extract out complex expressions
bidsmreye/combine.py process_subject 3 ⭐ 168 😞 15 😞 50.25% 🙂 Try splitting into smaller methods. Extract out complex expressions
bidsmreye/bidsutils.py check_layout 3 ⭐ 90 🙂 13 😞 62.21% 🙂 Extract out complex expressions
bidsmreye/prepare_data.py preprocess_subject 1 ⭐ 93 🙂 13 😞 63.78% 🙂 Extract out complex expressions
bidsmreye/prepare_data.py coregister_and_extract_data 0 ⭐ 36 ⭐ 10 😞 78.76% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #26 (ce6e15e) into main (d60f050) will increase coverage by 10.94%.
The diff coverage is 59.52%.

@@             Coverage Diff             @@
##             main      #26       +/-   ##
===========================================
+ Coverage   50.31%   61.25%   +10.94%     
===========================================
  Files           8        7        -1     
  Lines         318      302       -16     
===========================================
+ Hits          160      185       +25     
+ Misses        158      117       -41     
Flag Coverage Δ
tests 61.25% <59.52%> (+10.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bidsmreye/combine.py 95.00% <ø> (+1.81%) ⬆️
bidsmreye/prepare_data.py 0.00% <ø> (ø)
bidsmreye/run.py 0.00% <ø> (ø)
bidsmreye/generalize.py 52.83% <52.94%> (+52.83%) ⬆️
bidsmreye/utils.py 91.07% <85.71%> (-1.66%) ⬇️
bidsmreye/bidsutils.py 94.20% <100.00%> (+1.34%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[ENH] save one output per subject (Sourcery refactored)
@Remi-Gau Remi-Gau merged commit 25f84cd into main Jul 21, 2022
@Remi-Gau Remi-Gau deleted the refactor_confounds branch July 26, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

save one output per subject in subject folder
1 participant