Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] use logging #34

Merged
merged 3 commits into from
Jul 26, 2022
Merged

[ENH] use logging #34

merged 3 commits into from
Jul 26, 2022

Conversation

Remi-Gau
Copy link
Contributor

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 24, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.15%.

Quality metrics Before After Change
Complexity 2.92 ⭐ 3.68 ⭐ 0.76 👎
Method Length 55.97 ⭐ 60.70 ⭐ 4.73 👎
Working memory 8.65 🙂 8.61 🙂 -0.04 👍
Quality 71.21% 🙂 70.06% 🙂 -1.15% 👎
Other metrics Before After Change
Lines 911 1029 118
Changed files Quality Before Quality After Quality Change
bidsmreye/bidsutils.py 81.12% ⭐ 81.37% ⭐ 0.25% 👍
bidsmreye/combine.py 66.96% 🙂 67.78% 🙂 0.82% 👍
bidsmreye/generalize.py 52.29% 🙂 46.78% 😞 -5.51% 👎
bidsmreye/prepare_data.py 71.60% 🙂 72.29% 🙂 0.69% 👍
bidsmreye/run.py 51.64% 🙂 57.41% 🙂 5.77% 👍
bidsmreye/utils.py 82.89% ⭐ 75.40% ⭐ -7.49% 👎
tests/test_utils.py 87.41% ⭐ 87.86% ⭐ 0.45% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
bidsmreye/generalize.py generalize 9 🙂 259 ⛔ 17 ⛔ 36.06% 😞 Try splitting into smaller methods. Extract out complex expressions
bidsmreye/run.py main 9 🙂 229 ⛔ 10 😞 47.66% 😞 Try splitting into smaller methods. Extract out complex expressions
bidsmreye/combine.py process_subject 3 ⭐ 170 😞 15 😞 50.06% 🙂 Try splitting into smaller methods. Extract out complex expressions
bidsmreye/utils.py Config.__attrs_post_init__ 10 🙂 163 😞 8 🙂 56.16% 🙂 Try splitting into smaller methods
bidsmreye/bidsutils.py check_layout 3 ⭐ 90 🙂 13 😞 62.21% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Remi-Gau Remi-Gau merged commit 85317d8 into main Jul 26, 2022
@Remi-Gau Remi-Gau deleted the log branch July 26, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant