Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comparisons for decimal32 #729

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Improve comparisons for decimal32 #729

merged 3 commits into from
Sep 23, 2024

Conversation

mborland
Copy link
Member

Breaks the decoding of the type into multiple steps rather than doing it all up front, because it many cases that is unnecessary. Results in about a 6.5% speedup in all operations across decimal32.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.2%. Comparing base (0478b0c) to head (7f63f4f).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #729     +/-   ##
=========================================
- Coverage     99.2%   99.2%   -0.0%     
=========================================
  Files          224     224             
  Lines        16375   16398     +23     
  Branches      1778    1781      +3     
=========================================
+ Hits         16233   16255     +22     
- Misses         142     143      +1     
Files with missing lines Coverage Δ
include/boost/decimal/decimal32.hpp 98.8% <100.0%> (-<0.1%) ⬇️
include/boost/decimal/decimal64.hpp 99.3% <ø> (ø)
include/boost/decimal/detail/comparison.hpp 99.4% <100.0%> (+0.2%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0478b0c...7f63f4f. Read the comment docs.

@mborland mborland merged commit 9543df5 into develop Sep 23, 2024
65 checks passed
@mborland mborland deleted the better_comps branch September 23, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant