Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved comparisons for decimal64 #730

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Improved comparisons for decimal64 #730

merged 3 commits into from
Sep 24, 2024

Conversation

mborland
Copy link
Member

Provides a >30% speedup to decimal64s comparisons timing

@mborland mborland force-pushed the 64_bit_comps branch 3 times, most recently from c5ca919 to e37eb61 Compare September 24, 2024 17:32
@mborland mborland linked an issue Sep 24, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.2%. Comparing base (9543df5) to head (13726f3).
Report is 15 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #730     +/-   ##
=========================================
- Coverage     99.2%   99.2%   -0.0%     
=========================================
  Files          224     224             
  Lines        16398   16397      -1     
  Branches      1781    1780      -1     
=========================================
- Hits         16255   16254      -1     
  Misses         143     143             
Files with missing lines Coverage Δ
include/boost/decimal/decimal64.hpp 99.3% <100.0%> (-<0.1%) ⬇️
include/boost/decimal/detail/comparison.hpp 99.4% <100.0%> (+0.1%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9543df5...13726f3. Read the comment docs.

@mborland mborland merged commit 9e61fca into develop Sep 24, 2024
65 checks passed
@mborland mborland deleted the 64_bit_comps branch September 24, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate Comparisons
1 participant