Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster dec128 mul #733

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Faster dec128 mul #733

merged 3 commits into from
Sep 24, 2024

Conversation

mborland
Copy link
Member

Checking the number of digits is a O(log(n)) operation. If we can fit the result of significand multiplication into the range of a u128 then we avoid the 256-bit multiplication all together.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.2%. Comparing base (cb7f7b0) to head (c4bd2af).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
include/boost/decimal/detail/mul_impl.hpp 93.8% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #733     +/-   ##
=========================================
+ Coverage     99.2%   99.2%   +0.1%     
=========================================
  Files          224     224             
  Lines        16395   16401      +6     
  Branches      1779    1780      +1     
=========================================
+ Hits         16252   16261      +9     
+ Misses         143     140      -3     
Files with missing lines Coverage Δ
include/boost/decimal/decimal128.hpp 98.1% <ø> (-<0.1%) ⬇️
include/boost/decimal/decimal128_fast.hpp 97.6% <100.0%> (+0.1%) ⬆️
include/boost/decimal/detail/mul_impl.hpp 94.2% <93.8%> (+1.3%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb7f7b0...c4bd2af. Read the comment docs.

@mborland mborland merged commit 91811d0 into develop Sep 24, 2024
64 checks passed
@mborland mborland deleted the faster_dec128_mul branch September 24, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant