Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add initial documentation to external assets #1261

Merged
merged 3 commits into from
Oct 19, 2024
Merged

docs: add initial documentation to external assets #1261

merged 3 commits into from
Oct 19, 2024

Conversation

cpvalente
Copy link
Owner

@cpvalente cpvalente commented Oct 13, 2024

Feedback from @RasterboxOff:

  • the usage of external folders becomes more visible with the new menu and we would like to provide users a way to find out what they do

Also adding some small comments to the CSS properties

@alex-Arc , before we expose this, it would be a good change to review the structure
we plan on adding a sound file and a user given logo to the app
The sound file is part of Ontime
The logo belongs to the user

I wonder if the structure should be

my-app/
├─ projects/
├─ external/
│  ├─ demo/
├─ user/
│  ├─ styles/
│  │  ├─ override.css
│  ├─ sound/
│  │  ├─ alarm.mp3
│  ├─ logo/
│  │  ├─ logo.png```

@cpvalente cpvalente requested a review from alex-Arc October 13, 2024 08:39
@cpvalente cpvalente force-pushed the docs branch 4 times, most recently from 8e270ba to 0204eb0 Compare October 17, 2024 06:31
@cpvalente cpvalente merged commit cf40001 into master Oct 19, 2024
4 checks passed
@cpvalente cpvalente deleted the docs branch October 19, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants