Remove HSQL usage, consolidate application.yaml #623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream
hapi-fhir-jpaserver-starter
project made a few changes that make it more challenging to use an hsql database instead of h2. Specifically:jpaStarterDialectProvider
in the common config doesn't rely on the sameapplication.yaml
properties as the default dialect provider, resulting in different dialects being provideddriverClassName
is defaulted toorg.h2.Driver
hibernate.dialect
is defaulted toHapiFhirH2Dialect
That means that you have to override several different properties in order to configure a new database connection correctly:
spring.datasource.url
(spring can usually auto-detect the rest of the properties from this)spring.datasource.driverClassName
(unset to revert automatically detecting, override to specify another driver like postgres)spring.jpa.hibernate.dialect
(unset to revert automatically detecting, override to specify another driver like postgres)This PR gives up on hsql for the time being, switching back to the default H2. It also provides a new pattern for inheriting and overriding properties:
This allows you to just import the standard
hapi-fhir-jpaserver-starter
properties and override only the ones you want to, shrinking down our yaml files.