Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.crab extension #1

Merged
merged 2 commits into from
May 30, 2023
Merged

.crab extension #1

merged 2 commits into from
May 30, 2023

Conversation

trvswgnr
Copy link
Contributor

@trvswgnr trvswgnr commented May 30, 2023

this changes the file extension that cargo looks for (and uses in cargo new) from .rs to .crab. used with the renamed toolchain this can also be used with crabgo.

it currently needs to be built using the existing upstream cargo command. this isn't ideal, but to fix would probably require adding the ability to use both .rs and .crab, which would a more intense task.

to test:

/path/to/cargo build --release
/path/to/target/release/cargo new hello

for whatever reason, building cargo directly allows it to be renamed, where the normal install script does not. so doing this:

cp /path/to/target/release/cargo /path/to/.cargo/bin/crabgo

works fine and allows crabgo to live alongside cargo.

this resolves crablang/crab#20

@trvswgnr trvswgnr added the enhancement New feature or request label May 30, 2023
@trvswgnr trvswgnr self-assigned this May 30, 2023
@Cuteistfox
Copy link

what about .🦀 crablang/wastebasket#11

Copy link

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! ✅

@dreyfus92
Copy link

what about .🦀 crablang/wastebasket#11

I think that it is way much easier & faster to write crab, than to search for an emoji, imo.

@sammi-turner sammi-turner merged commit 7cc6600 into experimental May 30, 2023
@Cuteistfox
Copy link

Cuteistfox commented May 30, 2023

what about .crab crablang/wastebasket#11

I think that it is way much easier & faster to write crab, than to search for an emoji, imo.
@dreyfus92

purr @Lissy35 on crablang/crabgo#11

I mean, if Mojo can use the .🔥 ext, then crab lang should deffo jump on the trend with the .🦀!
@Lissy93

@Cuteistfox
Copy link

check out crablang/crab#2

@Cuteistfox
Copy link

-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

4 participants