Add support for query string in email URL field

[jean-gui]

Hi,

It would be useful if we could use values such as foo@bar.com?Subject=Test in a URL field that acts as an email.

Thanks!

[brandonkelly]

Just added this for the next release! (70398b3)

[brandonkelly]

3.7.24 is out now with that change.

[oblongd]

Hi @brandonkelly,

I believe this update (or another recent update) might have introduced an unintended side effect.

A client of mine just reported that adding or editing an external website link via a URL Field results in some new encoding being added when saved.

The issue arises when the URL contains a second URL inside a query parameter, and that URL also has query parameters. For example:

https://proxy.lcls.org:2443/login?url=https://link.gale.com/apps/TGLF?u=edwa30873
is converted to
https://proxy.lcls.org:2443/login?url=https%3A//link.gale.com/apps/TGLF%3Fu%3Dedwa30873

Unfortunately, this breaks the link through the proxy server, resulting in a 404.

Is there a config setting that can be used to disable URL encoding, or is this something that potentially needs to be addressed as a bugfix?

Thanks!

[brandonkelly]

@oblongd Yeah we started encoding query string params alongside this change, but we only really needed to encode spaces to +, so I just reverted that change and went with a simple → + string replace instead (5b65fcd).

To get that change early, change your craftcms/cms requirement in composer.json to "dev-develop as 3.7.25.1" and run composer update.

[oblongd]

Thanks, Brandon... I truly appreciate the fast response and quick fix.

Keep up the great work!

[brandonkelly]

Craft 3.7.26 is out with that change.

[oblongd]

Excellent! Thank you so much for the follow-up.

…

On Wed, Dec 15, 2021, 2:54 PM Brandon Kelly ***@***.***> wrote: Craft 3.7.26 is out with that change. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10193 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJVH3Z2LO67ABB7AEZBPHTURD6CDANCNFSM5JFDZQVA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.